Renamed DigraphDijkstra to DigraphShortestPaths#730
Renamed DigraphDijkstra to DigraphShortestPaths#730devansh2605 wants to merge 2 commits intodigraphs:mainfrom
DigraphDijkstra to DigraphShortestPaths#730Conversation
|
This is looking good! The only problem now (which I didn't mention before) is that we want to preserve backwards compatibility. So, now that |
|
Might even make sense to do something like we do is Semigroups and mark |
DigraphDijkstra to DigraphShortestPaths
|
Currently, I have renamed I had a suggestion on how to implement #735 as well:
|
|
This is dependent on #742, and should be updated before being merged. |
mtorpey
left a comment
There was a problem hiding this comment.
For now, could you use DeclareObsoleteSynonym to preserve backwards compatibility? You can find some examples of this in the GAP library.
| u := Pop(queue); | ||
| u := u[2]; | ||
| # TODO: this has a small performance impact for DigraphDijkstraS, | ||
| # TODO: this has a small performance impact for DigraphShortestPathsS, |
There was a problem hiding this comment.
I think this might be a typo that you've preserved with find-and-replace!
#570